Skip to content

Fix path not properly being shown without RnDiffApp #291

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucasbento
Copy link
Member

Summary

There was some sort of change when generating releases that caused the diff to change as following:

image

Which led upgrade-helper to show the header as:

image

It seems like the lib we use for parsing diff doesn't like the lack of those initial characters so I had to add some replaces here and there as well as maintain the RnDiffApp replace for the previous versions.

Test Plan

  • Open the dev preview;
  • Make sure that the paths are rendering correctly without the leading RnDiffApp but still using in specific places (such as RnDiffApp.xcodeproj);
  • Set a different app name;
  • Make sure that it renders correctly with the different app name.

What are the steps to reproduce?

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant